Create sanitize_input helper method for strings sent to run_command method. #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @xraystyle, thanks for the PR! Can you please check the used email address in your commit? It isn't associated with your github account. |
|
Ah, I haven't set an email address in my git config on my work laptop. Now that I've set it, do I need to re-create the pull request? |
|
updating the commit + doing a force push is enough. |
xraystyle
force-pushed
the
bugfix/shell-escape
branch
from
fd823b8
to
c1fd795
Compare
|
Done, should be good now. Author email is one of the emails associated with my github account. |
|
@xraystyle Great catch here, that's a pretty big security gap. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that this Sinatra app is vulnerable to shell injection when it runs the commands generated by the :deploy and :deploy_module methods. This patch adds a simple helper method to shell-escape this input, and is called on the strings before they're passed to the above methods. Adds no additional dependencies, Shellwords is part of the Ruby standard library.