Add option to lowercase environment names #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://docs.puppetlabs.com/puppet/latest/reference/lang_reserved.html#environments, environment names can only include lowercase characters *. As such, downcase the environment we're trying to deploy, otherwise parts of the PE stack can get quite cranky with you. This is a major change, though, so default to the old behaviour of allowing uppercase names through. * Empirically validated. The Puppet Master can handle uppercased environment names, but the Console (maybe other components as well) cannot. That means that the Console will assign the downcased environment name, which doesn't actually exist on disk :-/
acidprime
added a commit
that referenced
this pull request
Nov 20, 2015
Add option to lowercase environment names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to
https://docs.puppetlabs.com/puppet/latest/reference/lang_reserved.html#environments,
environment names can only include lowercase characters *. As such,
downcase the environment we're trying to deploy, otherwise parts of the
PE stack can get quite cranky with you. This is a major change, though, so
default to the old behaviour of allowing uppercase names through.
environment names, but the Console (maybe other components as well)
cannot. That means that the Console will assign the downcased
environment name, which doesn't actually exist on disk :-/