add support for yum provider #20
Conversation
After talking with @adrienthebo, distro packages of r10k should have git as a runtime dependency. If they don't, they are broken and should be fixed
|
@tampakrap i'm not following your comments. Are you proposing adding yum to the same case as pe_gem? I didn't do that because RHEL based systems prefix gem packages with 'rubygem-'. |
new URL for the make module
| } | ||
| end | ||
| it { should include_class("git") } | ||
| it { should_not contain_package("rubyge-r10k")} |
There was a problem hiding this comment.
Typo in the package name here
require git only when installing via gem or bundler
|
@jlambert121 Thanks for the pull request, I agree that the yum does not necessarily need to be in the same case statement as pe_gem and gem for the time being. If you can rebase the updates in .fixtures.yml and fix your spec typo I will merge ( need to think about the recent conditional git change as well https://github.com/acidprime/r10k/pull/22 ) |
|
I just filed PR #24 as alternative for this one |
|
Skimming #24 it looks like a better solution utilizing the params class rather than extending the conditional. |
|
I thought about it as well but unfortunately it's not possible. We need to set $package_name based on the final value of $provider, not the default value of $provider |
|
Yeah I am going to close this in lieu of #24 |
Added support for the yum provider. I also had to mock the make dependency in the spec because it is no longer a valid git repo (but it exists on the forge).
Looking at the comments in the install, is < 1.0 support still needed?