add fact caching logic for failed lookups #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rdark I haven't had much time to keep an eye on pull requests for this project; sorry for the delay! Is this something you'll still be able to work on? |
|
@adrienthebo - "still be able to work on" as in actually write some tests for it? (or at least make it not break existing ones) ;) |
|
We yanked the network facts, so this is no longer necessary. Thanks for the contribution regardless and sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writes out a cache file on every successful lookup of network_public_ip, uses it if it can't reach the public service for any reason.
Really useful for avoiding inevitable cluster-fuckery with reconfiguring critical parts of infrastructure because an external service was unavailable.