Allow Type network_config to take a Numeric value for the MTU parameter #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump. Anyone? |
igalic
reviewed
Aug 22, 2017
| expect do | ||
| Puppet::Type.type(:network_config).new(name: 'yay', mtu: 1500.1) | ||
| end.to raise_error | ||
| end |
There was a problem hiding this comment.
can you also add non-number tests, just to be sure?
There was a problem hiding this comment.
There are non numbered tests, they were the original tests - it assumed a String. I just added numerical tests.
|
thank you very much, @lukebigum! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's feasible to provide a Numeric type to the MTU parameter in Puppet 4 (such as the result of a calculation). This patch allows the network_config Type to accept a Numeric as well as a String, and tests for all the same expected failure cases with numeric values.