Fix issue 69, backwards incompatible change #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some style checks fail for puppet 4.0, I'll fix them when I have time again so that this can be merged. In the meantime, please review this patch and let me know if anything else needs fixing. |
|
Seems good to me, once tests are fixed. |
|
looks fine. Could you please also add a note in the CHANGELOG.md? |
|
It looks like most of the rubocop failures can be autocorrected. |
The debian provider for network_routes now names default routes as 'default' and not 'default/netmask'. This makes it work like the [2;2Rt [>1;2802;0cpuRedHat one does. Update README to explain this. Also the 0.0.0.0 netmask is written for default routes.
rski
force-pushed
the
route_every_run_update
branch
from
8af7b1f to
4d82e81
Compare
|
Should be fine now |
rnelson0
added a commit
that referenced
this pull request
May 11, 2016
#165 is backwards incompatible, bumping the rc version string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debian provider for network_routes now names default routes as
'default' and not 'default/netmask'. This makes it work like the
RedHat one does. Update README to explain this. Also the 0.0.0.0
netmask is written for default routes.