rubocop fixes, split a really long line #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return '' if providers.empty? | ||
| raise Puppet::DevError,\ | ||
| "Unable to support multiple interfaces [#{providers.map(&:name).join(',')}] in a single file #{filename}"\ | ||
| if providers.length > 1 |
There was a problem hiding this comment.
are the \s really necessary?
There was a problem hiding this comment.
the first one isn't because of the comma, but the second one is not optional. I'm impartial to having either ,\ or just ,
|
Ok, before you merge this, let me squash into it a fix for the badge in the readme because I just noticed it no longer seems to show up |
jyaworski
added a commit
that referenced
this pull request
Mar 11, 2016
rubocop fixes, split a really long line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #141