Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update version dependencies for boolean and filemappper #237

Closed
kfowler-embue opened this issue Jan 8, 2018 · 2 comments
Closed

update version dependencies for boolean and filemappper #237

kfowler-embue opened this issue Jan 8, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@kfowler-embue
Copy link

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 5.3.3
  • Ruby: 2.4.2p198
  • Distribution: ubuntu 16.04
  • Module version: 0.9.0

How to reproduce (e.g Puppet code you use)

puppet module list

What are you seeing

this module limits versions of dependencies (boolean, filemapper) below their current versions

What behaviour did you expect instead

Expect the latest version of this module to be able to use the latest versions of its dependencies.

Output log

puppet module list

Warning: Module 'puppet-boolean' (v2.0.0) fails to meet some dependencies:
'puppet-network' (v0.9.0) requires 'puppet-boolean' (>= 1.0.1 < 2.0.0)
Warning: Module 'puppet-filemapper' (v3.0.0) fails to meet some dependencies:
'puppet-network' (v0.9.0) requires 'puppet-filemapper' (>= 2.0.1 < 3.0.0)

Any additional information you'd like to impart

I understand that the dependency version ranges were probably valid for a long while and that both boolean and and filemapper just went to versions that broke the version rule. I was guessing that your module would likely be okay with the latest dependencies but needed to be tested with them.

@bastelfreak
Copy link
Member

Hi @kfowler-embue, thanks for this issue. Can you provide a PR which bumps the version boundaries?

@juniorsysadmin juniorsysadmin added the enhancement New feature or request label Jan 8, 2018
kevpfowler added a commit to kevpfowler/puppet-network that referenced this issue Jan 9, 2018
bastelfreak added a commit that referenced this issue Jan 9, 2018
#237: increase version boundary for boolean and filemapper dependencies
@bastelfreak
Copy link
Member

Fixed by #238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants