Merge pull request #143 from rski/fix_absent_in_redhat_files

Make :absent attributes not get written to redhat files

Author: igalic

lib/puppet/provider/network_config/redhat.rb

@@ -184,7 +184,7 @@ def self.format_file(filename, providers)
 
     # Map everything to a flat hash
     NAME_MAPPINGS.keys.each do |type_name|
-      if (val = provider.send(type_name))
+      if (val = provider.send(type_name)) && val != :absent
         props[type_name] = val
       end
     end

spec/unit/provider/network_config/redhat_spec.rb

@@ -376,6 +376,22 @@ def fixture_data(file)
       )
     end
 
+    let(:eth1_provider) do
+      stub('eth1_provider',
+           :name            => 'eth1',
+           :ensure          => :present,
+           :onboot          => :absent,
+           :hotplug         => true,
+           :family          => 'inet',
+           :method          => 'none',
+           :ipaddress       => :absent,
+           :netmask         => :absent,
+           :mtu             => :absent,
+           :mode            => :vlan,
+           :options         => :absent,
+          )
+    end
+
     let(:lo_provider) do
       stub('lo_provider',
            :name            => 'lo',
@@ -439,6 +455,14 @@ def fixture_data(file)
       it { expect(data).to match(/VLAN=yes/) }
     end
 
+    describe 'with test interface eth1' do
+      let(:data) { described_class.format_file('filepath', [eth1_provider]) }
+
+      it { expect(data).to match(/DEVICE=eth1/) }
+      it { expect(data).to match(/VLAN=yes/) }
+      it { expect(data).to_not match(/absent/) }
+    end
+
     describe 'with test interface bond0' do
       let(:data) { described_class.format_file('filepath', [bond0_provider]) }