Make :absent attributes not get written to redhat files #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@igalic I'll definitely will but it will take a bit cause I have absolutely 0 experience with ruby/puppet testing |
|
@rski i'm pretty & sure most of us have started there. |
|
@igalic Oh I'm not complaining. I'm quite happy that i get to learn this, it's just that it won't be ready today |
rski
force-pushed
the
fix_absent_in_redhat_files
branch
from
1b52858 to
831fa0c
Compare
Fix issue 142. Make the redhat provider not write lines of the form VALUE=absent in the configuration files. Also provide tests for this fix and the one provided by 487bc6c.
rski
force-pushed
the
fix_absent_in_redhat_files
branch
from
831fa0c to
0015352
Compare
|
Updated with actual tests |
igalic
added a commit
that referenced
this pull request
Mar 11, 2016
Make :absent attributes not get written to redhat files
|
thanks @rski! |
|
thanks for everything @igalic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #142. Make the redhat provider not write lines of
the form VALUE=absent in the configuration files.