Add interfaces order #147
Annotations
10 errors and 3 warnings
spec/unit/provider/network_config/interfaces_spec.rb#L261
Puppet::Type::Network_config::ProviderInterfaces when formatting writing the auto section allows at most one section
Failure/Error: stanza << ('auto ' + auto_interfaces.sort_by { |provider| interface_order(provider.name, provider.order_rules) }.map(&:name).join(' '))
#<InstanceDouble(lo_provider) (anonymous)> received unexpected message :order_rules with (no args)
|
spec/unit/provider/network_config/interfaces_spec.rb#L265
Puppet::Type::Network_config::ProviderInterfaces when formatting writing the auto section has the correct interfaces appended
Failure/Error: stanza << ('auto ' + auto_interfaces.sort_by { |provider| interface_order(provider.name, provider.order_rules) }.map(&:name).join(' '))
#<InstanceDouble(lo_provider) (anonymous)> received unexpected message :order_rules with (no args)
|
spec/unit/provider/network_config/interfaces_spec.rb#L273
Puppet::Type::Network_config::ProviderInterfaces when formatting writing only the auto section skips the allow-hotplug line
Failure/Error: stanza << ('auto ' + auto_interfaces.sort_by { |provider| interface_order(provider.name, provider.order_rules) }.map(&:name).join(' '))
#<InstanceDouble(lo_provider) (anonymous)> received unexpected message :order_rules with (no args)
|
spec/unit/provider/network_config/interfaces_spec.rb#L279
Puppet::Type::Network_config::ProviderInterfaces when formatting writing the allow-hotplug section allows at most one section
Failure/Error: stanza << ('auto ' + auto_interfaces.sort_by { |provider| interface_order(provider.name, provider.order_rules) }.map(&:name).join(' '))
#<InstanceDouble(lo_provider) (anonymous)> received unexpected message :order_rules with (no args)
|
spec/unit/provider/network_config/interfaces_spec.rb#L283
Puppet::Type::Network_config::ProviderInterfaces when formatting writing the allow-hotplug section has the correct interfaces appended
Failure/Error: stanza << ('auto ' + auto_interfaces.sort_by { |provider| interface_order(provider.name, provider.order_rules) }.map(&:name).join(' '))
#<InstanceDouble(lo_provider) (anonymous)> received unexpected message :order_rules with (no args)
|
spec/unit/provider/network_config/interfaces_spec.rb#L291
Puppet::Type::Network_config::ProviderInterfaces when formatting writing only the allow-hotplug section skips the auto line
Failure/Error: stanza << ('allow-hotplug ' + hotplug_interfaces.sort_by { |provider| interface_order(provider.name, provider.order_rules) }.map(&:name).join(' '))
#<InstanceDouble(eth1_provider) (anonymous)> received unexpected message :order_rules with (no args)
|
spec/unit/provider/network_config/interfaces_spec.rb#L299
Puppet::Type::Network_config::ProviderInterfaces when formatting writing iface blocks produces an iface block for each interface
Failure/Error: stanza << ('auto ' + auto_interfaces.sort_by { |provider| interface_order(provider.name, provider.order_rules) }.map(&:name).join(' '))
#<InstanceDouble(lo_provider) (anonymous)> received unexpected message :order_rules with (no args)
|
spec/unit/provider/network_config/interfaces_spec.rb#L303
Puppet::Type::Network_config::ProviderInterfaces when formatting writing iface blocks adds all options following the iface block
Failure/Error: stanza << ('auto ' + auto_interfaces.sort_by { |provider| interface_order(provider.name, provider.order_rules) }.map(&:name).join(' '))
#<InstanceDouble(lo_provider) (anonymous)> received unexpected message :order_rules with (no args)
|
spec/unit/provider/network_config/interfaces_spec.rb#L313
Puppet::Type::Network_config::ProviderInterfaces when formatting writing iface blocks fails if the family property is not defined
Failure/Error: expect { content }.to raise_exception(%r{does not have a family})
expected Exception with message matching /does not have a family/, got #<RSpec::Mocks::MockExpectationError: #<InstanceDouble(lo_provider) (anonymous)> received unexpected message :order_rules with (no args)> with backtrace:
# ./lib/puppet/provider/network_config/interfaces.rb:260:in `block in format_file'
# ./lib/puppet/provider/network_config/interfaces.rb:260:in `each'
# ./lib/puppet/provider/network_config/interfaces.rb:260:in `sort_by'
# ./lib/puppet/provider/network_config/interfaces.rb:260:in `format_file'
# ./spec/unit/provider/network_config/interfaces_spec.rb:297:in `block (4 levels) in <top (required)>'
# ./spec/unit/provider/network_config/interfaces_spec.rb:315:in `block (5 levels) in <top (required)>'
# ./spec/unit/provider/network_config/interfaces_spec.rb:315:in `block (4 levels) in <top (required)>'
|
spec/unit/provider/network_config/interfaces_spec.rb#L318
Puppet::Type::Network_config::ProviderInterfaces when formatting writing iface blocks fails if the method property is not defined
Failure/Error: expect { content }.to raise_exception(%r{does not have a method})
expected Exception with message matching /does not have a method/, got #<RSpec::Mocks::MockExpectationError: #<InstanceDouble(lo_provider) (anonymous)> received unexpected message :order_rules with (no args)> with backtrace:
# ./lib/puppet/provider/network_config/interfaces.rb:260:in `block in format_file'
# ./lib/puppet/provider/network_config/interfaces.rb:260:in `each'
# ./lib/puppet/provider/network_config/interfaces.rb:260:in `sort_by'
# ./lib/puppet/provider/network_config/interfaces.rb:260:in `format_file'
# ./spec/unit/provider/network_config/interfaces_spec.rb:297:in `block (4 levels) in <top (required)>'
# ./spec/unit/provider/network_config/interfaces_spec.rb:320:in `block (5 levels) in <top (required)>'
# ./spec/unit/provider/network_config/interfaces_spec.rb:320:in `block (4 levels) in <top (required)>'
|
spec/unit/type/network_config_spec.rb#L68
Puppet::Type::Network_config when validating the attribute options is a descendant of the KeyValue property
Failure/Error: expect(Puppet::Type.type(:network_config).propertybyname(:options).ancestors).to include(Puppet::Property::Ensure)
expected [Puppet::Type::Network_config::Options, Puppet::Property, Puppet::Parameter, Puppet::Util::Logging, P...ator::GeneratorMethods::Object, JSON::Ext::Generator::GeneratorMethods::Object, Kernel, BasicObject] to include Puppet::Property::Ensure
Diff:
@@ -1,13 +1,25 @@
-[Puppet::Property::Ensure]
+[Puppet::Type::Network_config::Options,
+ Puppet::Property,
+ Puppet::Parameter,
+ Puppet::Util::Logging,
+ Puppet::Util::Errors,
+ Puppet::Util,
+ Object,
+ RspecPuppetFacts,
+ FastGettext::Translation,
+ PSON::Pure::Generator::GeneratorMethods::Object,
+ JSON::Ext::Generator::GeneratorMethods::Object,
+ Kernel,
+ BasicObject]
|
spec/unit/type/network_config_spec.rb#L85
Puppet::Type::Network_config when validating the attribute value ipaddress using the inet family fails when passed an IPv6 address
Failure/Error: expect { Puppet::Type.type(:network_config).new(name: 'yay', family: :inet, ipaddress: address6) }.to raise_error(%r{not a valid ipv4 address})
expected Exception with message matching /not a valid ipv4 address/ but nothing was raised
|
spec/unit/type/network_config_spec.rb#L96
Puppet::Type::Network_config when validating the attribute value ipaddress using the inet6 family fails when passed an IPv4 address
Failure/Error: expect { Puppet::Type.type(:network_config).new(name: 'yay', family: :inet6, ipaddress: address4) }.to raise_error(%r{not a valid ipv6 address})
expected Exception with message matching /not a valid ipv6 address/ but nothing was raised
|
This job failed
Loading