-
-
Notifications
You must be signed in to change notification settings - Fork 446
Add support for RHEL 7 #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
EPEL 7 packages mongodb with a different pidfile path than prior package versions. This commit updates the pidfile path in params.pp so that the service can start if installed from epel. It also fixes the spec helper so that iptables can be stopped on RHEL 7.
@@ -35,6 +35,9 @@ | |||
when 'RedHat' | |||
on hosts, 'puppet module install stahnma-epel' | |||
apply_manifest_on hosts, 'include epel' | |||
if fact('operatingsystemrelease') =~ /^7/ | |||
shell('yum install -y iptables-services') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be on hosts
if we want the replset tests to work (because they are multi-host): https://github.com/puppetlabs/puppetlabs-mongodb/blob/master/spec/acceptance/replset_spec.rb
Agreed @hunner but this is a pattern we are already using which will only apply to default host which is required with newer versions of beaker. |
@cyberious The "pattern we are already using" doesn't apply to this module, since if you look at the rest of the spec helper you'll see that the de facto pattern is to use In multi-node tests there is no "default host," though there may be a host with the default role. |
perhaps an |
Ah yes, |
Since the rest of this spec helper is using |
Any reason for opening a new PR as opposed to accepting an exiting one in #148. Just asking… |
The additional change to ensure spec acceptance worked as well for rhel 7 is my guess that a new PR was cut. |
Add support for RHEL 7
EPEL 7 packages mongodb with a different pidfile path than prior
package versions. This commit updates the pidfile path in params.pp so
that the service can start if installed from epel. It also fixes the
spec helper so that iptables can be stopped on RHEL 7.