Skip to content

Add support for RHEL 7 #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2015
Merged

Add support for RHEL 7 #154

merged 1 commit into from
Jan 5, 2015

Conversation

cmurphy
Copy link
Contributor

@cmurphy cmurphy commented Jan 5, 2015

EPEL 7 packages mongodb with a different pidfile path than prior
package versions. This commit updates the pidfile path in params.pp so
that the service can start if installed from epel. It also fixes the
spec helper so that iptables can be stopped on RHEL 7.

EPEL 7 packages mongodb with a different pidfile path than prior
package versions. This commit updates the pidfile path in params.pp so
that the service can start if installed from epel. It also fixes the
spec helper so that iptables can be stopped on RHEL 7.
cyberious added a commit that referenced this pull request Jan 5, 2015
@cyberious cyberious merged commit 799d22b into voxpupuli:master Jan 5, 2015
@@ -35,6 +35,9 @@
when 'RedHat'
on hosts, 'puppet module install stahnma-epel'
apply_manifest_on hosts, 'include epel'
if fact('operatingsystemrelease') =~ /^7/
shell('yum install -y iptables-services')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be on hosts if we want the replset tests to work (because they are multi-host): https://github.com/puppetlabs/puppetlabs-mongodb/blob/master/spec/acceptance/replset_spec.rb

@cyberious
Copy link
Contributor

Agreed @hunner but this is a pattern we are already using which will only apply to default host which is required with newer versions of beaker.

@hunner
Copy link
Member

hunner commented Jan 5, 2015

@cyberious The "pattern we are already using" doesn't apply to this module, since if you look at the rest of the spec helper you'll see that the de facto pattern is to use on hosts (precisely because of the multi-node tests).

In multi-node tests there is no "default host," though there may be a host with the default role.

@cyberious
Copy link
Contributor

perhaps an on agents or on hosts should be updated if this is a requirement of mongodb testing.

@hunner
Copy link
Member

hunner commented Jan 5, 2015

Ah yes, on agents would probably be preferable; the tests were written using POSS and masterless so I didn't have that issue.

@cmurphy
Copy link
Contributor Author

cmurphy commented Jan 5, 2015

Since the rest of this spec helper is using on hosts I think it is best to use on hosts for this line as well since the rest of the test setup is being applied to all hosts. PR in #155

@iNecas
Copy link
Contributor

iNecas commented Jan 6, 2015

Any reason for opening a new PR as opposed to accepting an exiting one in #148. Just asking…

@cyberious
Copy link
Contributor

The additional change to ensure spec acceptance worked as well for rhel 7 is my guess that a new PR was cut.

@cmurphy
Copy link
Contributor Author

cmurphy commented Jan 6, 2015

@iNecas I apologize, I scanned the PR queue for this fix and #148 didn't catch my eye. I should have actually examined it. Looking at it now, it looks like a more complete solution, so I will revert this one and merge the other.

cegeka-jenkins pushed a commit to cegeka/puppet-mongodb that referenced this pull request Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants