Closes #18: merging @mheistermann's changes #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue copy-paste from #16 When you install letsencrypt using the VCS method, it will create a virtualenv, which would normally be located in ~/.local/share/letsencrypt: Excerpt from letsencrypt-auto: ``` XDG_DATA_HOME=${XDG_DATA_HOME:-~/.local/share} VENV_NAME="letsencrypt" VENV_PATH=${VENV_PATH:-"$XDG_DATA_HOME/$VENV_NAME"} ``` However, puppet exec's will not set $HOME, which will stop Debian's /bin/sh, dash, from expanding ~, so it creates a literal '~' folder.
Using the `cron_success_command` parameter for `certonly`, you can run commands when the renewal command was successful, e.g. reload the webserver to use the renewed certs. Not sure about letsencrypt return values, so the command might be executed even if the cert is unchanged, doesn't matter for this usecase though.
… into cron_success_cmd Conflicts: manifests/certonly.pp manifests/init.pp manifests/params.pp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.