Fix misuse of fqdn_rand_string #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
approved these changes
Jun 16, 2022
smortex
requested changes
Jun 16, 2022
According to the puppetlabs-stdlib documentation, fqdn_rand_string()'s second argument is the character set to use when generating the random string, and its third argument is the seed. The certonly class incorrectly passes the domain name as the second argument, causing fqdn_rand_string() to use the host's fqdn as the seed, resulting in more-frequent-than-necessary hash collisions. The current implementation of fqdn_rand() seems to provide sufficient randomness, so fqdn_rand_string() doesn't seem to be necessary.
smokris
force-pushed
the
fqdn_rand_string
branch
from
bfc9f37 to
28d67f5
Compare
|
Thanks, @smortex! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
According to the puppetlabs-stdlib documentation,
fqdn_rand_string()'s second argument is the character set to use
when generating the random string, and its third argument is
the seed. The certonly class incorrectly passes the domain name
as the second argument, causing fqdn_rand_string() to use the
host's fqdn as the seed, resulting in more-frequent-than-necessary
hash collisions.
This Pull Request (PR) fixes the following issues
(no issue)