Skip to content

Fix wrong type user param #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

pazmarianoj
Copy link
Contributor

Pull Request (PR) description

This is just a minor fix of the 'user' parameter type that was mistakenly defined as 'Optional[String]' when it required to be 'Optional[Hash]'

This Pull Request (PR) fixes the following issues

Fixes #220

@LongLiveCHIEF
Copy link
Contributor

@edransmpaz can you take anything not related to the user param out of this merge request, and then rebase? Thanks!

@pazmarianoj
Copy link
Contributor Author

@LongLiveCHIEF I believe that the issue mentioned on this PR is already resolved in other one that was merged days ago. #219 So I can close this PR.

@LongLiveCHIEF
Copy link
Contributor

I thought so, but wanted to make sure. Thanks for confirming!

@pazmarianoj pazmarianoj deleted the fix-wrong-type-user-param branch April 25, 2018 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants