Add EL8 support and claim compatibility #527
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@optiz0r , can you rebase on the current master branch? |
dadez73
pushed a commit
to dadez73/puppet-corosync
that referenced
this pull request
Oct 8, 2024
bastelfreak
force-pushed
the
issue526_el8_compat
branch
2 times, most recently
from
bab13ec to
6fa79f6
Compare
bastelfreak
force-pushed
the
issue526_el8_compat
branch
from
6fa79f6 to
ef5200d
Compare
bastelfreak
pushed a commit
to bastelfreak/puppet-corosync
that referenced
this pull request
Mar 14, 2025
bastelfreak
pushed a commit
to bastelfreak/puppet-corosync
that referenced
this pull request
Oct 1, 2025
bastelfreak
pushed a commit
to bastelfreak/puppet-corosync
that referenced
this pull request
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Rework of #484 against latest master branch.
The version of corosync uses a cli parameter instead of an environment variable to point at the config file to be tested. Without this change, the env var is ignored and the
config_validate_cmdcommand always checks the real config file location before installing the candidate file. On a new build, this will fail because the real config file does not yet exist. When being updated, the real config file is checked, instead of the candidate file, so an invalid change might be falsely reported as acceptable and lead to an outage.This change overrides the config validate command on el8 to use the correct syntax.
It also lists el8 as a compatible OS in the module metadata, since the module is currently being used with this patch in production.
This Pull Request (PR) fixes the following issues
Fixes #526
Obsoletes #484