Add configuration/support for NFVPE plugins #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paramite
force-pushed
the
feature/nfvpe-plugins
branch
2 times, most recently
from
ee5ff52 to
26cf834
Compare
bastelfreak
reviewed
Jul 26, 2018
manifests/plugin/connectivity.pp
Outdated
| class collectd::plugin::connectivity ( | ||
| Enum['present', 'absent'] $ensure = 'present', | ||
| Boolean $manage_package = $collectd::manage_package, | ||
| Array[String] $interfaces = [], |
There was a problem hiding this comment.
can you update this to Array[String[1]]? That enforces a minimal string length of one.
bastelfreak
reviewed
Jul 26, 2018
manifests/plugin/sysevent.pp
Outdated
| Enum['present', 'absent'] $ensure = 'present', | ||
| Boolean $manage_package = $collectd::manage_package, | ||
| Stdlib::Host $listen_host = '127.0.0.1', | ||
| Integer $listen_port = 6666, |
There was a problem hiding this comment.
Can you use this type please? https://github.com/puppetlabs/puppetlabs-stdlib/blob/master/types/port.pp. We then need to make sure that stdlib 4.25.0 is the lowest supported version in our metadata.json
bastelfreak
reviewed
Jul 26, 2018
manifests/plugin/procevent.pp
Outdated
| Boolean $manage_package = $collectd::manage_package, | ||
| Optional[String] $process = undef, | ||
| Optional[String] $regex_process = undef, | ||
| Optional[Integer] $buffer_length = undef, |
There was a problem hiding this comment.
You can also enforce that this has to be a positive integer: https://puppet.com/docs/puppet/5.5/lang_data_number.html#the-integer-data-type
paramite
force-pushed
the
feature/nfvpe-plugins
branch
from
26cf834 to
0e8043a
Compare
bastelfreak
reviewed
Jul 27, 2018
manifests/plugin/procevent.pp
Outdated
| class collectd::plugin::procevent ( | ||
| Enum['present', 'absent'] $ensure = 'present', | ||
| Boolean $manage_package = $collectd::manage_package, | ||
| Optional[String] $process = undef, |
There was a problem hiding this comment.
can you use Optional[String[1]] here?
bastelfreak
reviewed
Jul 27, 2018
manifests/plugin/procevent.pp
Outdated
| Enum['present', 'absent'] $ensure = 'present', | ||
| Boolean $manage_package = $collectd::manage_package, | ||
| Optional[String] $process = undef, | ||
| Optional[String] $regex_process = undef, |
There was a problem hiding this comment.
can you use Optional[String[1]] here?
bastelfreak
added
enhancement
This patch adds support for NFVPE plugins, namely: sysevent, procevent and connectivity
paramite
force-pushed
the
feature/nfvpe-plugins
branch
from
0e8043a to
28c2b15
Compare
|
Thanks! |
bastelfreak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This patch adds support for NFVPE plugins, namely: sysevent, procevent and connectivity.
Those plugins are not merged yet in collectd itself, but once this (hopefully) happens,
we will have configuration patch ready for merge.
Collectd patches:
collectd/collectd#2624
collectd/collectd#2623
collectd/collectd#2622
This Pull Request (PR) fixes the following issues
n/a