Merge pull request #944 from paramite/write_http

Add support for Header and Metrics configuration for write_http plugin
voxpupuli · May 28, 2020 · 5d466cf · 5d466cf
2 parents d73d5f4 + a418545
commit 5d466cf
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 0 deletions.
diff --git a/spec/classes/collectd_plugin_write_http_spec.rb b/spec/classes/collectd_plugin_write_http_spec.rb
@@ -60,6 +60,30 @@
         end
       end
 
+      context ':ensure => present and :nodes => { \'collectd\' => { \'url\' => \'collectd.org.1\', \'metrics\' => \'true\', \'header\' => \'foobar\'}}' do
+        let :params do
+          {
+            nodes:
+              {
+                'collectd' =>
+                  {
+                    'url' => 'collectd.org.1',
+                    'metrics' => true,
+                    'header' => 'foobar'
+                  }
+              }
+          }
+        end
+
+        it 'Will create 10-write_http.conf' do
+          is_expected.to contain_file('write_http.load').with(
+            ensure: 'present',
+            path: "#{options[:plugin_conf_dir]}/10-write_http.conf",
+            content: "#\ Generated by Puppet\n<LoadPlugin write_http>\n  Globals false\n</LoadPlugin>\n\n<Plugin \"write_http\">\n  <Node \"collectd\">\n    URL \"collectd.org.1\"\n\n    Header \"foobar\"\n    Metrics true\n  </Node>\n\n</Plugin>\n\n"
+          )
+        end
+      end
+
       context ':ensure => absent' do
         let :params do
           { ensure: 'absent' }

diff --git a/templates/plugin/write_http.conf.epp b/templates/plugin/write_http.conf.epp
@@ -28,6 +28,12 @@
 <% if $values['storerates'] { -%>
     StoreRates <%= $values['storerates'] %>
 <% } -%>
+<% if $values['header'] { -%>
+    Header "<%= $values['header'] %>"
+<% } -%>
+<% if $values['metrics'] { -%>
+    Metrics <%= $values['metrics'] %>
+<% } -%>
 <% if $values['url'] { -%>
   </Node>
 <% } else { -%>