Skip to content

Switch from puppet to openvox #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 10, 2025
Merged

Switch from puppet to openvox #2

merged 10 commits into from
Jun 10, 2025

Conversation

bastelfreak
Copy link
Member

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@bastelfreak bastelfreak self-assigned this May 30, 2025
@bastelfreak bastelfreak force-pushed the openvox branch 7 times, most recently from d54199b to 1f7c359 Compare May 30, 2025 21:00
@bastelfreak bastelfreak requested a review from ekohl May 30, 2025 21:02
@bastelfreak bastelfreak force-pushed the openvox branch 2 times, most recently from ca0189a to 0ec50c6 Compare May 30, 2025 21:26
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a partial review but 👍 for our own version. I should say I suggested this on IRC

PuppetLint.configuration.send('disable_80chars')
PuppetLint.configuration.ignore_paths = %w(acceptance/**/*.pp spec/**/*.pp pkg/**/*.pp)

desc 'Validate Ruby source files and ERB templates.'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this still useful?

@ekohl
Copy link
Member

ekohl commented Jun 4, 2025

I think we need to:

  • Move the namespace to properly reflect the move
  • Add the proper dependencies in OpenVox itself so we don't need the Gemfile workaround

@bastelfreak
Copy link
Member Author

Add the proper dependencies in OpenVox itself so we don't need the Gemfile workaround

done

@bastelfreak
Copy link
Member Author

CI not also lists all installed gems and it doesn't pull in puppet anymore

ekohl and others added 3 commits June 10, 2025 19:43
    git mv lib/puppet-strings lib/openvox-strings
    git mv lib/puppet-strings.rb lib/openvox-strings.rb
    git mv spec/unit/puppet-strings spec/unit/openvox-strings
    sed -i 's/puppet-strings/openvox-strings/g' $(rg puppet-strings lib/ spec/ Rakefile *.gemspec README.md CONTRIBUTING.md -l)
    sed -i 's/PuppetStrings/OpenvoxStrings/g' $(rg PuppetStrings -l)
@bastelfreak bastelfreak force-pushed the openvox branch 2 times, most recently from 79fba61 to aac765e Compare June 10, 2025 17:51
@bastelfreak bastelfreak merged commit f88755e into main Jun 10, 2025
6 checks passed
@bastelfreak bastelfreak deleted the openvox branch June 10, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants