-
-
Notifications
You must be signed in to change notification settings - Fork 0
Switch from puppet to openvox #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d54199b
to
1f7c359
Compare
ca0189a
to
0ec50c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a partial review but 👍 for our own version. I should say I suggested this on IRC
PuppetLint.configuration.send('disable_80chars') | ||
PuppetLint.configuration.ignore_paths = %w(acceptance/**/*.pp spec/**/*.pp pkg/**/*.pp) | ||
|
||
desc 'Validate Ruby source files and ERB templates.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this still useful?
2c9cfcd
to
4b2dfc7
Compare
I think we need to:
|
done |
CI not also lists all installed gems and it doesn't pull in |
git mv lib/puppet-strings lib/openvox-strings git mv lib/puppet-strings.rb lib/openvox-strings.rb git mv spec/unit/puppet-strings spec/unit/openvox-strings sed -i 's/puppet-strings/openvox-strings/g' $(rg puppet-strings lib/ spec/ Rakefile *.gemspec README.md CONTRIBUTING.md -l) sed -i 's/PuppetStrings/OpenvoxStrings/g' $(rg PuppetStrings -l)
79fba61
to
aac765e
Compare
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist