(#77)(#78) Add default factset tests and fix failures #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note this PR supercedes #54 |
glennsarti
force-pushed
the
add-more-factset-tests
branch
from
826afb7
to
a17206e
Compare
|
@DavidS I've added your revert here |
|
Also added the submodule ref fix to help Travis. |
DavidS
approved these changes
Mar 26, 2018
|
Needs the constants in the number_of_files tests fixed up though. 🤷♂️ |
|
Still Work in Progress. Fixing the broken tests |
glennsarti
force-pushed
the
add-more-factset-tests
branch
2 times, most recently
from
bc80a67
to
09ebdc8
Compare
|
Fixed |
glennsarti
force-pushed
the
add-more-factset-tests
branch
from
09ebdc8
to
9da09c4
Compare
Previously the facterdb_spec test had hardcode values for external fact paths and file counts. This commit refactors out the hardcoded file counts and uses rspec let statements to provide the information. This commit also cleans up the expectations to expect exact values instead of greater than.
Previously there were many default fact files which are just duplicates. This commit adds a test will performs a simple file hash comparison of all default factset files and fails and displays any duplicate factsets. This test is initially skipped while the duplicate files are removed in later commits.
This commit removes the duplicate and redundant fact sets for Solaris 11.
This reverts commit f568b6a. The original commit contained a number of factsets that were not of the facter version specified in the pathname. Reverting this for now to avoid distributing erroneous data.
This commit removes the duplicate and redundant fact sets for Solaris 10.
Previosuly the test for unique factsets was created but skipped while the duplicate files were removed. Now that the files have been removed, this test can be enforced.
Previously many factset files were in the wrong directory which made maintenance and debugging difficult. This commit adds tests to ensure that the factset files are indeed JSON parsable and that the facter version in the file matches the directory it is located in. This test is maked as skipped until all of the bad factset files can be changed.
Previously the factset files for SLES 12 were in the wrong location. This commit moves the SLES factset files From: 1.6 to 1.7 1.7 to 2.0 2.0 to 2.1 2.1 to 2.2 2.3 to 2.4 2.4 to 1.6
Previously the PC6 factset file was placed in the 2.4 directory however the facter version is 3.6. This commit moves the file to the correct location.
The factset for Amazon 2017 in the 2.5 directory has a facter version of 1.6. Looking at the factset in the 1.6 directory, this is just a copy of that set. This commit removes the incorrect and redundant factset file.
Previously the test for factset file directory was created but skipped while the factset files were fixed. Now that the files have been fixed, this test can be enforced.
Previously the git submodule reference for the Hugo theme was using git:. This can be troublesome for Travis and freshly created git environments. This commit changes the git submodule to use the more friendly HTTPS uri.
This commit updates the README after the factsets had been cleaned up.
rodjek
force-pushed
the
add-more-factset-tests
branch
from
9da09c4
to
4a3d7da
Compare
1 similar comment
This was referenced Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there were many default fact files which are just duplicates. This
PR adds a test will performs a simple file hash comparison of all default
factset files and fails and displays any duplicate factsets.
Previously many factset files were in the wrong directory which made maintenance
and debugging difficult. This PR adds tests to ensure that the factset
files are indeed JSON parsable and that the facter version in the file matches
the directory it is located in.