openSUSE Support #63
Merged
openSUSE Support #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just wanted to follow up on this to see what's needed to get it included in a new release of your awesome gem |
|
LGTM |
|
Thanks @mcanevet. Any thoughts on how to get other versions of Leap into here without them going into the same file? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added Vagrant boxes for several more versions of openSUSE and generated facts for openSUSE Leap 42.3. I did not generate facts for other versions of Leap due to it seeming like they would all go into the same file. I also did not generate for Tumbleweed due to it going into a file called opensuse-4-x86_64.facts.
If you have suggestions on how to resolve either the overlap issue so that we can have the different versions of Leap or the issue of file name for Tumbleweed I'd be happy to add more to this.