Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernized Windows Support and documentation update #306

Merged
merged 2 commits into from
May 14, 2024
Merged

Modernized Windows Support and documentation update #306

merged 2 commits into from
May 14, 2024

Conversation

yakatz
Copy link
Contributor

@yakatz yakatz commented Mar 19, 2024

Three parts to this:

  1. Support for generating Windows facts automatically
  2. The Windows facts themselves
  3. Rewriting the documentation for fact generation with the aim of ensuring repeatable builds

@yakatz
Copy link
Contributor Author

yakatz commented Mar 19, 2024

The tests fail because none of the new files contain legacy facts. I saw the discussion on #266 (which has been open for a year). Should I bother adding them or will that change also happen?

@zilchms
Copy link
Contributor

zilchms commented Mar 20, 2024 •
edited
Loading

Looks good to me on principle. One question though: Do you happen to know why we are loosing some facts for the already present windows-10-facts for example? Are those the missing legacy facts you pointed out? In that case I think we should include the legacy facts everywhere and remove them at a later date maybe. Puppet 7 isnt EOL yet, so the legacy facts can still be used (even if highly discouraged).

@yakatz yakatz force-pushed the windows branch 2 times, most recently from abf8ba9 to e27423c Compare March 21, 2024 20:00
@yakatz
Copy link
Contributor Author

yakatz commented Mar 21, 2024

The tests fail because none of the new files contain legacy facts. I saw the discussion on #266 (which has been open for a year). Should I bother adding them or will that change also happen?

Added them back

@yakatz yakatz requested a review from zilchms March 21, 2024 20:56
@yakatz
Copy link
Contributor Author

yakatz commented Mar 24, 2024 •
edited
Loading

Rebased on current master (and resigned with GPG)

bastelfreak
bastelfreak reviewed May 14, 2024
View reviewed changes
facts/README.md Outdated Show resolved Hide resolved
@yakatz yakatz force-pushed the windows branch 2 times, most recently from 86ae78a to 248d240 Compare May 14, 2024 21:12
@yakatz
Copy link
Contributor Author

yakatz commented May 14, 2024

@bastelfreak All the changes you requested are done

@yakatz yakatz requested a review from bastelfreak May 14, 2024 21:27
@bastelfreak bastelfreak merged commit 426068b into voxpupuli:master May 14, 2024
7 checks passed
@yakatz yakatz deleted the windows branch May 14, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zilchms zilchms zilchms approved these changes

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yakatz @zilchms @bastelfreak