Windows updates for facter 4.2 #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Nov 14, 2022
facts/4.2/windows-10-x86_64.facts
Outdated
| "windows_installation_type": "Client", | ||
| "windows_product_name": "Windows 10 Pro", | ||
| "windows_release_id": "22H2" | ||
| } |
There was a problem hiding this comment.
can you fix the missing newline in the factsets?
bastelfreak
reviewed
Nov 14, 2022
| "windows_product_name": "Windows Server 2022 Datacenter", | ||
| "windows_release_id": "21H2" | ||
| } | ||
|
|
There was a problem hiding this comment.
please check this missing newline as well
bastelfreak
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using https://github.com/puppetlabs/puppetlabs-pecdm the following images were created and then had facter with legacy facts run
MicrosoftWindowsDesktop:windows10preview:win10-22h2-pro:latest
MicrosoftWindowsDesktop:windows11preview:win11-22h2-pro:latest
MicrosoftWindowsServer:WindowsServer:2019-datacenter-smalldisk:latest
MicrosoftWindowsServer:WindowsServer:2022-datacenter-smalldisk:latest
MicrosoftWindowsServer:WindowsServer:2022-datacenter-core-smalldisk:latest
MicrosoftWindowsServer:WindowsServer:2019-datacenter-core-smalldisk:latest
Removed azure_metadata and cloud facts.
Generalised hostnames to foo.example.com