Fix Red Hat facts on version 4.2

[anders-larsson]

Current fact file for redhat-9 seems to have been made using a CentOS system as template. However this does not properly reflect a Red Hat 9 system. Most important change in this is adding os.distro.release.minor and os.release.minor and updating operatingsystemrelease, os.distro.release.full, and os.release.full to match the values for a Red Hat 9 system.

Took the opportunity to update codename, description and id to match Red Hat too.

Found this issue when adding support for EL9 in a class where it worked for previous versions of EL.

[bastelfreak]

@anders-larsson thanks for the PR. We've some redhat facts for othe facter versions as well. can you take a look at those as well?

[anders-larsson]

@anders-larsson thanks for the PR. We've some redhat facts for othe facter versions as well. can you take a look at those as well?

Hello,

I'll have a look. Thanks.

[anders-larsson]

How strict should it be? File https://github.com/voxpupuli/facterdb/blob/master/facts/4.2/redhat-7-x86_64.facts seems to have been generated using CentOS Stream since release is set to 7.8.2003 which is only used for by CentOS (Stream). However it contains everything that is required for it to work on Red Hat systems.

Maybe worth updating since os.release.full/os.distro.release.full is set to 7.8.2003 which might be used in spec tests though?

[ekohl]

Ideally speaking it really is the output of puppet facts show --show-legacy according to https://github.com/voxpupuli/facterdb#add-new-operating-system-support so if you have a real RHEL system, please share the real data. As you say, users could be parsing the full release and create bugs if the data doesn't match.

[anders-larsson]

Took a little bit of time due to local environment setup. Included fact file is for a completely vanilla (minimal) redhat-9 system. Only puppet-agent installed. Changed hostname, fqdn, domain and a few other values (for privacy) using the same values as was previously used.

Is this the information we want? I'm not sure why the sorting of values is different now (os is one) now compared to previous file. Used the command mentioned by ekohl. If this is the information we want I'll try to fix it for redhat-7 and redhat-8 from facter 4.2.

[anders-larsson]

I've updated all Red Hat related files for 4.2. I hope this is suitable for your needs. Please tell me if any changes are required. All is default installations for RHEL.

[ekohl]

Thanks for sorting. The diff is now much easier to consume.

[ekohl]

It'd be slightly easier if there wasn't a virbr0, but it doesn't really matter that much.

[anders-larsson]

Not sure why it was created. I should be able to filter it out.

[anders-larsson]

Should be fixed in most recent commit.

[ekohl]

Thanks!