Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #19 - add filter validation #159

Merged
merged 1 commit into from
Oct 10, 2020

Conversation

logicminds
Copy link
Contributor

  • Previously there was not a way to validate if a filter was
    legit or not. This adds a new method that exposes the jgrep
    validation interface to facterdb.

    Additionally, it also refactors the get_facts method by adding
    an intermediary method to generate the filter string.

    I have also added a new error class for throwing a better error
    message to the user.

    Lastly, I added some method documention for all the methods I touched.

  * Previously there was not a way to validate if a filter was
    legit or not.  This adds a new method that exposes the jgrep
    validation interface to facterdb.

    Additionally, it also refactors the get_facts method by adding
    an intermediary method to generate the filter string.

    I have also added a new error class for throwing a better error
    message to the user.

    Lastly, I added some method documention for all the methods I touched.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6816271 on nwops:filter_validation into d5cd0b9 on camptocamp:master.

@mcanevet mcanevet merged commit 784c77c into voxpupuli:master Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants