Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fact sets for SLES15 #121

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Add fact sets for SLES15 #121

merged 1 commit into from
Jul 24, 2019

Conversation

rodjek
Copy link
Member

@rodjek rodjek commented Jul 24, 2019

@rodjek rodjek merged commit d0c1711 into voxpupuli:master Jul 24, 2019
@rodjek rodjek deleted the sles-15 branch July 24, 2019 06:02
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 84f2037 on rodjek:sles-15 into 96ec245 on camptocamp:master.

@baurmatt
Copy link
Contributor

baurmatt commented Aug 8, 2019

Hey @rodjek,

I just stumbled over a problem with this change. Some of the newly introduced facts sets don't have a "operatingsystem" fact. In particular those are:

  • 2.2
  • 2.3
  • 2.4
  • 2.5

This leads to problem with rspec-puppet-facts-unsupported.

I'm not 100% sure, but shouldn't every fact set (especially for a "enterprise" OS as this one) have a "operatingsystem" fact?

@rodjek
Copy link
Member Author

rodjek commented Aug 12, 2019

They don't have an operatingsystem fact because Facter 2.x doesn't return one for SLES15. This is the behaviour of Facter 2.x on that distro, so I think FacterDB should show this and rspec-puppet-facts-unsupported should be updated to not assume the presence of this fact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants