Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-enable by puppetlabs disabled puppet-lint checks #48

Merged
merged 2 commits into from
Sep 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ rake syntax:templates
rake test # Run tests
rake travis_release # Deprecated: use the "release" task instead
rake validate # Check syntax of Ruby files and call :syntax and :metadata_lint
rake voxpupuli:custom:lint_all # Lint with all puppet-lint checks
```

## Additionally included Tools
Expand Down
24 changes: 24 additions & 0 deletions voxbox/Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,27 @@ require 'voxpupuli/release/rake_tasks'
require 'ra10ke'

Ra10ke::RakeTask.new

namespace :voxpupuli do
namespace :custom do
desc 'Lint with all puppet-lint checks'
task :lint_all do
# re-enable by puppetlabs disabled checks from puppetlabs/spec_helper
# see: https://github.com/puppetlabs/puppetlabs_spec_helper/blob/70de49db0a242f83e9ff39ea8a03c830339f8368/lib/puppetlabs_spec_helper/rake_tasks.rb#L169-L177
puppet_lint_enable_checks = %w[
140chars
class_inherits_from_params_class
class_parameter_defaults
autoloader_layout
documentation
single_quote_string_with_variables
]

puppet_lint_enable_checks.each do |check|
PuppetLint.configuration.send(:"enable_#{check}")
end

Rake::Task[:lint].invoke
end
end
end