Video annotation: timeline toolbar + media info bar#7666
Open
tom-vx51 wants to merge 4 commits into
Open
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (4)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
erik-nieh
approved these changes
May 29, 2026
Reuse the existing per-frame detection's _id when applying linear propagation so in-between frames are overwritten in place (replace) instead of appending a duplicate that only the shared instance id masked. Record the parent keyframes' mongo _ids in the propagation blob instead of the cross-frame-stable synthetic overlay id (identical for both ends of a track). Test updated to lock in _id provenance.
Optional node rendered between the playback control buttons and the playhead time display, threaded TimelineWithTracks -> TimelineHeader -> TimelineControls. Defaults to nothing; existing timelines unchanged.
… propagate) Mark Keyframe / Propagate actions in the timeline controls row via the new controlsSlot. Driven by a ToolbarActionGroup config (useVideoAnnotationActions) matching @fiftyone/components' ActionToolbar shape, so actions are added by editing the hook, not the renderer. Extract resolvePropagationTarget as shared eligibility/bracketing logic and route the '-' keybinding through it so button and hotkey can't drift.
Member
Author
This was referenced May 31, 2026
tom-vx51
changed the title
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issues
None
📋 What changes are proposed in this pull request?
Adds a toolbar and a media information bar to the video annotation surface.
controlsSlotin the timeline header for injecting custom controls between the transport buttons and the playhead time display. Defaults to nothing; existing timelines are unchanged._id(an in-place replace rather than a duplicate add) and records the parent keyframes' ids in the provenance blob.Stacked on #7686.
🧪 How is this patch tested? If it is not, please explain why.
Tested locally in the app.
📝 Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
What areas of FiftyOne does this PR affect?
fiftyonePython library changes