fit limit for confusion matrix in model eval

[imanjra]

What changes are proposed in this pull request?

fit limit for confusion matrix in model eval when there are no missing counts

How is this patch tested? If it is not, please explain why.

Using model evaluation panel

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

• No. You can skip the rest of this section.
• Yes. Give a description of this change to be included in the release
  notes for FiftyOne users.

See above

What areas of FiftyOne does this PR affect?

• App: FiftyOne application changes
• Build: Build and test infrastructure changes
• Core: Core fiftyone Python library changes
• Documentation: FiftyOne documentation changes
• Other

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of classification labels in the evaluation matrix
  • Enhanced logic for including special class labels in data processing

The changes refine the matrix generation process to more accurately manage class representations during evaluation.

[coderabbitai]

Walkthrough

The pull request introduces a modification to the getMatrix function in the Evaluation.tsx file. The change enhances the condition for including the NONE_CLASS in the labels and matrix. The updated logic ensures that the NONE_CLASS is only added when it exists in the originalClasses array and meets the specified limit condition. This refinement provides more precise control over the matrix generation process.

Changes

File	Change Summary
app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Evaluation.tsx	Modified getMatrix function to add an additional condition checking noneIndex for including NONE_CLASS in labels and matrix

Suggested labels

enhancement

Suggested reviewers

• brimoor

Possibly related PRs

• various model evaluation fixes and enhancements #5123: Modification of Evaluation.tsx component's getMatrix function
• model evaluation bug fixes #5166: Updates to getMatrix function in Evaluation.tsx
• fix confusion matrix in model evaluation panel #5186: Changes to getMatrix function focusing on confusion matrix handling
• bugfix: y-axis autorange reversed on all evaluation chart #5193: Layout configurations for confusion matrices in Evaluation.tsx
• Fixing #5254 #5267: New logic for handling evaluation types in Evaluation.tsx
• Optimize view callbacks for model evaluation panel #5268: Enhanced filtering logic in Evaluation.tsx

Poem

🐰 In the matrix of code, a rabbit's delight,
A subtle change, making conditions just right
NONE_CLASS now dances with precision and grace
Hopping through logic with algorithmic embrace
A whisker of wisdom in evaluation's space! 🧮

Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Evaluation.tsx (1)

1682-1682: LGTM! Good defensive programming.

The additional check noneIndex > -1 ensures that NONE_CLASS exists in the original classes before attempting to add it. This prevents potential issues with invalid array access and improves the robustness of the matrix generation.

Consider extracting the condition into a descriptive variable for better readability:

-  if (parsedLimit < originalClasses.length && noneIndex > -1) {
+  const shouldAddNoneClass = parsedLimit < originalClasses.length && noneIndex > -1;
+  if (shouldAddNoneClass) {

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c5d3bf5 and e370d30.

📒 Files selected for processing (1)

• app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Evaluation.tsx (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

app/packages/core/src/plugins/SchemaIO/components/NativeModelEvaluationView/Evaluation.tsx (1)

Pattern **/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: test / test-python (ubuntu-latest-m, 3.11)
• GitHub Check: test / test-python (ubuntu-latest-m, 3.10)
• GitHub Check: test / test-app
• GitHub Check: e2e / test-e2e
• GitHub Check: lint / eslint
• GitHub Check: build / build