Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating dependencies for build workflows #1411

Merged
merged 7 commits into from
Nov 15, 2021
Merged

Updating dependencies for build workflows #1411

merged 7 commits into from
Nov 15, 2021

Conversation

brimoor
Copy link
Contributor

@brimoor brimoor commented Nov 11, 2021

Adds requirements/extras.txt for extra packages that can be cross-platform installed via pip for certain optional features.

These requirements are now installed in docs/package build workflows (these had gotten out-of-date and were breaking the docs builds of late).

Unfortunately things like torch, tensorflow, and pycocotools can't be included in this because they require Windows-specific installs.

@brimoor brimoor self-assigned this Nov 11, 2021
@brimoor brimoor added ci GitHub actions and other continuous integration tasks dependencies Pull requests that update a dependency file labels Nov 11, 2021
@brimoor
Copy link
Contributor Author

brimoor commented Nov 13, 2021

Note to self: this issue seems relevant

Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brimoor brimoor merged commit 28eaafb into develop Nov 15, 2021
@brimoor brimoor deleted the build-deps branch November 15, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci GitHub actions and other continuous integration tasks dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants