Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

Expose public methods in VideoController #64

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Expose public methods in VideoController #64

merged 1 commit into from
Oct 11, 2023

Conversation

djova-dolby
Copy link
Contributor

  • Allow for registering with conference after the fact
  • Allow for creating renderer after the fact

@djova-dolby djova-dolby requested a review from abuszta October 10, 2023 08:06
@djova-dolby
Expose public methods in VideoController
698c4d9 
- Allow for registering with conference after the fact
- Allow for creating renderer after the fact
@djova-dolby djova-dolby force-pushed the feature/try_fix_vc_register branch from f84af5c to 698c4d9 Compare October 10, 2023 08:10
leeprobert
leeprobert approved these changes Oct 10, 2023
View reviewed changes
Copy link

@leeprobert leeprobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will give us way more flexibility. i would suggest looking at some of the other Start and Awake methods in the ConferenceController and the DolbyIOManager to see if deferred instantiation of these classes would be problematic in some way. Thank you.

@djova-dolby
Copy link
Contributor Author

@abuszta lets merge this one then.

@djova-dolby djova-dolby merged commit fd0ffb1 into main Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leeprobert leeprobert leeprobert approved these changes

@abuszta abuszta abuszta approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djova-dolby @leeprobert @abuszta