Add exportTo() alias to avoid reserved word issues #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`export` is a reserved word in JavaScript, so it is illegal to use it as an identifier. Many linting tools will complain about a regular call to export(module), requiring the following (ugly) fix: - ).export(module); + )['export'](module); To encourage good style while maintaining backwards compatibility, the exportTo(module) alias can be used as a syntactically valid replacement for export(module). Closely related issue/fix in vows: vowsjs/vows#27 vowsjs/vows@398443d
|
Thanks. Cherry-picked. Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exportis a reserved word in JavaScript, so it is illegal to use it asan identifier. Many linting tools will complain about a regular call to
export(module), requiring the following (ugly) fix:
To encourage good style while maintaining backwards compatibility,
the exportTo(module) alias can be used as a syntactically valid
replacement for export(module).
Closely related issue/fix in vows:
vowsjs/vows#27
vowsjs/vows@398443d