fix(jsonl): define module logger after imports to satisfy E402#399
Merged
Conversation
vouchdev#361 inserted `_log = logging.getLogger(...)` between two import groups in jsonl_server.py. that statement-among-imports trips ruff's E402 on every import that follows it, so `ruff check src tests` — the lint gate in ci — now fails on the whole repo. move the logger definition below the imports (where storage.py already keeps its own module logger); no behaviour change.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#361 (RPC traceback-leak fix) inserted
_log = logging.getLogger("vouch.jsonl_server")between two import groups insrc/vouch/jsonl_server.py. a module-level statement in the middle of the imports trips ruff'sE402(module import not at top of file) on every import that follows it — six of them — soruff check src tests, the lint step in ci, now fails on the wholetestbranch. any pr opened or re-run after #361 landed goes red on lint through no fault of its own.this moves the logger definition to just below the import block, exactly where
storage.pyalready keeps its own module logger (_log = logging.getLogger("vouch.storage")). no behaviour change — same logger, same name, defined a few lines lower.Test Plan
ruff check src tests→All checks passed!(was: 6 × E402)pytest tests/test_jsonl_server.pygreenmypy srccleanbefore (on current
test):after: clean.