fix(models): reject empty text/name/title on Claim/Entity/Page

[minion1227]

What changed

Claim.text, Entity.name, and Page.title now reject empty /
whitespace-only values at the model layer, via @field_validators that
mirror the existing Claim.evidence min-citation validator (#81/#82).

Why

the non-empty contract for these fields lived only in the propose_*
helpers, so three other write paths slipped through:

• direct construction — Claim(text=""), Entity(name=""),
  Page(title="") were all accepted, and store.put_* landed the
  YAML / markdown on disk.
• bundle / sync import — bundle._validate_content calls
  <Model>.model_validate(...), which had no text-content validator, so a
  manifest-consistent bundle with blank fields imported cleanly.
• mutate-then-update — claim.text = ""; store.update_claim(claim)
  re-validates via model_validate, but with no validator the blank
  persisted.

enforcing on the model closes all three at once — exactly the
contract-vs-enforcement asymmetry that #81/#82 fixed for Claim.evidence.
closes #155.

What might break

nothing on disk or on the wire. this only rejects artifacts that were never
semantically valid (blank text / name / title). existing well-formed KBs are
unaffected. the validators gate on emptiness only and preserve the
surrounding whitespace of non-blank values (no silent stripping). a KB that
somehow already holds a blank-field artifact will surface it as a
validation error on next load — which is the intended signal, matching how
the #81 evidence validator behaves.

Source.locator is intentionally out of scope (the issue flags its
format question as bigger and deserving its own issue).

VEP

not a surface change — a model-layer validation tightening in the same shape
already merged for Claim.evidence. no VEP needed.

Tests

• make check — ruff clean; mypy clean on touched files; pytest green
  (the only local failures are pre-existing and environment-only:
  fastapi/[web] not installed and embeddings installed, both of
  which also fail on main)
• new behaviour has tests in tests/test_storage.py (alongside the
  bug: Claim model has no min-evidence validator — uncited claims land via bundle import, put_claim, update_claim #81 evidence-validator tests): model-construction rejection
  (empty + whitespace, parametrised), put_* rejection with
  no-file-landed assertions, update_claim mutate-then-persist
  rejection, and a whitespace-preservation guard for non-blank values
• CHANGELOG.md updated under ## [Unreleased]

Summary by CodeRabbit

• Bug Fixes
  • Empty or whitespace-only values are now rejected for claim text, entity names, and page titles.
  • Storage operations now consistently block blank values from being created or updated, closing gaps in non-proposal write paths.
  • Added regression tests ensuring invalid inputs are rejected while valid text remains unchanged.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c88f6183-d3af-44ba-b2a8-7167d8e9ef82

📥 Commits

Reviewing files that changed from the base of the PR and between 536c4ce and 89815c0.

📒 Files selected for processing (2)

• CHANGELOG.md
• src/vouch/models.py

✅ Files skipped from review due to trivial changes (1)

• CHANGELOG.md

---

📝 Walkthrough

Walkthrough

Adds model-level validators that reject empty or whitespace-only Claim.text, Entity.name, and Page.title. Storage regression tests cover construction and write/update paths, and the changelog records the validation change.

Changes

Model-layer non-empty validation

Layer / File(s)	Summary
Claim.text validator and coverage src/vouch/models.py, tests/test_storage.py	Adds a shared non-empty helper and a Claim.text validator; tests cover blank-value rejection, put_claim/update_claim behavior, and whitespace preservation.
Entity.name validator and coverage src/vouch/models.py, tests/test_storage.py	Adds an Entity.name validator; tests cover blank-value rejection and put_entity behavior.
Page.title validator, coverage, and changelog src/vouch/models.py, tests/test_storage.py, CHANGELOG.md	Adds a Page.title validator; tests cover blank-value rejection and put_page behavior, and the changelog notes the fix.

Estimated code review effort: 2 (Simple) | ~15 minutes

Possibly related issues

• bug: Claim model has no min-evidence validator — uncited claims land via bundle import, put_claim, update_claim #81 — Related model-level validation work in src/vouch/models.py, but for Claim.evidence rather than these text fields.

Poem

A bunny hops through fields of code,
To guard each name and title load.
No blank little whispers slip through the wire,
Just honest words and validators that don’t tire. 🐇

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 35.29% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly states the core change: rejecting empty text/name/title in Claim, Entity, and Page models.
Linked Issues check	✅ Passed	The validators and tests address the linked gap by enforcing non-empty values at the model layer for all three fields.
Out of Scope Changes check	✅ Passed	The changelog update, helper extraction, and regression tests all support the stated validation fix.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

src/vouch/models.py (1)

235-245: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Consider extracting shared non-empty validator helper.

_text_non_empty, _name_non_empty, and _title_non_empty are structurally identical (strip-check + raise ValueError). A small shared helper (e.g. _require_non_empty(v: str, field_label: str) -> str) called from each @field_validator would remove the duplication while keeping the per-field error messages.

♻️ Proposed refactor

+def _require_non_empty(v: str, label: str) -> str:
+    if not v.strip():
+        raise ValueError(f"{label} must not be empty")
+    return v
+
+
 class Claim(BaseModel):
     ...
     `@field_validator`("text")
     `@classmethod`
     def _text_non_empty(cls, v: str) -> str:
-        if not v.strip():
-            raise ValueError("claim text must not be empty")
-        return v
+        return _require_non_empty(v, "claim text")

Apply the same pattern to Entity._name_non_empty and Page._title_non_empty.

Also applies to: 281-288, 338-345

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/vouch/models.py` around lines 235 - 245, Extract the duplicated
strip-and-empty validation logic in the model validators into a shared helper
such as _require_non_empty(v, field_label), then have _text_non_empty,
Entity._name_non_empty, and Page._title_non_empty call it so each field keeps
its own error message without repeating the same check. Keep the existing field
validators in place and replace the repeated if not v.strip(): raise
ValueError(...) blocks with the shared helper to reduce duplication across the
affected validators.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@CHANGELOG.md`:
- Line 99: Capitalize the sentence start in the changelog entry so the text
after the period begins with “The” instead of “the”. Update the affected
CHANGELOG.md entry only, keeping the rest of the release note unchanged.

---

Nitpick comments:
In `@src/vouch/models.py`:
- Around line 235-245: Extract the duplicated strip-and-empty validation logic
in the model validators into a shared helper such as _require_non_empty(v,
field_label), then have _text_non_empty, Entity._name_non_empty, and
Page._title_non_empty call it so each field keeps its own error message without
repeating the same check. Keep the existing field validators in place and
replace the repeated if not v.strip(): raise ValueError(...) blocks with the
shared helper to reduce duplication across the affected validators.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: dac51ccc-7071-47be-a22f-7902ad39d843

📥 Commits

Reviewing files that changed from the base of the PR and between 94e84b1 and 536c4ce.

📒 Files selected for processing (3)

• CHANGELOG.md
• src/vouch/models.py
• tests/test_storage.py

[minion1227]

thanks — addressed both in 89815c0:

• extracted a shared module-level _require_non_empty(v, label) helper; the
  three validators now delegate to it, keeping their per-field messages.
• fixed the mid-entry sentence casing in the CHANGELOG.

no behaviour change; tests and assertions unchanged and green.