feat(desktop): add the electron desktop app under desktop/ (monorepo)#285
Merged
Conversation
brings the vouch-desktop electron app into the repo as a monorepo directory. desktop/ is a self-contained typescript + react + vite + electron app that drives vouch as a child process over the jsonl and review-ui transports, and never writes durable kb state except through the review gate. node_modules/, out/, dist/, and release/ are gitignored via desktop/.gitignore; only source is committed (78 files). the python ci gate is unaffected — ruff, mypy, and pytest target src/ and tests/, not desktop/. note: this softens the repo's "buildless, no npm" guidance to "buildless python package, with the node/vite toolchain fenced under desktop/".
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
makes vouch a monorepo by bringing the
vouch-desktopelectron app into therepo under
desktop/. it's a self-contained typescript + react +vite + electron app that puts a GUI on the full
kb.*surface, drivingvouchas a child process over the JSONL and review-ui transports. it never writes
durable KB state except through the review gate (
propose → approve).what's added
desktop/— 78 source files: electron main/preload (src/main,src/preload),a react/vite renderer (
src/renderer), the generated method catalog(
src/catalog),electron.vite.config.ts,electron-builder.yml, build assets,docs, and screenshots.
hygiene
node_modules/,out/,dist/,release/are gitignored viadesktop/.gitignore— only source is committed (0 build/dependency paths).ruff/mypy/pytesttargetsrc/andtests/, notdesktop/. no workflow referencesdesktop/.note for reviewers
this is a policy shift worth a conscious sign-off: it introduces a node/vite
toolchain into the repo, softening the "buildless, no npm in the repo" rule to
"buildless python package, with the desktop app fenced under
desktop/."the toolchain is fully contained in that directory; nothing about the python
package's build or test flow changes.