Skip to content

test: Initial commit for tests#17

Merged
vot merged 4 commits intovot:masterfrom
anishkny:scaffold-tests
Oct 26, 2018
Merged

test: Initial commit for tests#17
vot merged 4 commits intovot:masterfrom
anishkny:scaffold-tests

Conversation

@anishkny
Copy link
Contributor

@anishkny anishkny commented Oct 25, 2018

Includes:

Fixes #16

@vot
Copy link
Owner

vot commented Oct 26, 2018

Hey @anishkny,

This is great - thanks for adding scaffolding for tests.
Never used nyc so curious about differences between this and istanbul.

Merging now

@vot vot merged commit a745994 into vot:master Oct 26, 2018
@anishkny
Copy link
Contributor Author

I believe they rebranded istanbul to nyc. Its basically the same thing.

@vot
Copy link
Owner

vot commented Oct 26, 2018

Hah that'd explain it - I remember seeing it in a few places but never looked into it :)

Once again many thanks for sorting this out. I've already set up Coveralls integration and updated the badge in readme.
Everything works exactly as expected 👍

@anishkny anishkny mentioned this pull request Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants