Add "Temporal" option to pca fullfr #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temporal (boolean) : Whether to use rather left or right singularvectors
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #583 +/- ##
==========================================
- Coverage 63.78% 63.56% -0.22%
==========================================
Files 56 56
Lines 12172 12208 +36
==========================================
- Hits 7763 7759 -4
- Misses 4409 4449 +40
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
+ add test for the modes + add warning for incompatible modes
|
|
Oupsi
+ Add cases to not compute U if not asked for modes ('eigen', 'eigencupy', 'eigenpytorch')
It always returns the 3 values.
Not taking into account the pixels under the mask when computing temporal pc's required to discard those pixels from the vectorized images. This is done in prepare_matrix() : If, discard_mask_pix is set to True, Then, mask_circle is asked to return a boolean mask instead of a masked array The array is truncated accordingly to the boolean mask before being flattened. Then, _svd_wrapper takes into account the spatially truncated vectors to compute the full temporal pc's. Then project the full matrix (with regular 0-filled mask) on the pc's 👍
|
I changed the way the central mask was applied when computing the time pc's. |
|
Thanks a lot @Sand-jrd ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
temporal (boolean) : Whether to use rather left or right singularvectors
