Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests updated after a correction in the class ScatteredLight #579

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

jmilou
Copy link
Contributor

@jmilou jmilou commented Mar 8, 2023

I reviewed the last test that failed in test_fm_scatteredlight and updated it

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2023

Codecov Report

Merging #579 (69242f6) into master (5678765) will increase coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #579      +/-   ##
==========================================
+ Coverage   63.84%   63.85%   +0.01%     
==========================================
  Files          56       56              
  Lines       12118    12119       +1     
==========================================
+ Hits         7736     7738       +2     
+ Misses       4382     4381       -1     
Impacted Files Coverage Δ
vip_hci/fm/scattered_light_disk.py 68.30% <100.00%> (+0.07%) ⬆️
vip_hci/fm/negfc_mcmc.py 70.21% <0.00%> (+0.16%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@VChristiaens VChristiaens merged commit 2acb768 into vortex-exoplanet:master Mar 8, 2023
@VChristiaens
Copy link
Contributor

Thanks @jmilou! All tests have now passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants