Skip to content

Conversation

IainHammond
Copy link
Contributor

here is my affiliation and contribution to the paper, it looks great! note i didn't edit the entire file paragraph, i think the line length changed so git thinks it was completely re-done

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2022

Codecov Report

Merging #529 (594a16a) into master (032000b) will not change coverage.
The diff coverage is n/a.

❗ Current head 594a16a differs from pull request most recent head 217a2d5. Consider uploading reports for the commit 217a2d5 to get more accurate results

@@           Coverage Diff           @@
##           master     #529   +/-   ##
=======================================
  Coverage   43.64%   43.64%           
=======================================
  Files          54       54           
  Lines       10312    10312           
=======================================
  Hits         4501     4501           
  Misses       5811     5811           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@VChristiaens VChristiaens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback! I'd like to accept most of the proposed changes, but a couple. To make it easier, could you just replace the few locations as per the comments I left? Thanks!

@IainHammond
Copy link
Contributor Author

implemented the suggestions above

@VChristiaens VChristiaens merged commit a1079e0 into vortex-exoplanet:master Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants