Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions bench-orchestrator/bench_orchestrator/runner/executor.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,10 @@ def run(
else:
cmd = cmd_prefix + cmd

if samply and self.engine == Engine.DUCKDB:
# Re-use the same DuckDB instance across runs make samply output readable
cmd += ["--reuse"]

if self.verbose:
console.print(f"[dim]$ {' '.join(cmd)}[/dim]")

Expand Down
13 changes: 12 additions & 1 deletion benchmarks/duckdb-bench/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,14 @@ struct Args {
/// Print EXPLAIN output for each query instead of running benchmarks.
#[arg(long, default_value_t = false)]
explain: bool,

#[arg(
long,
default_value_t = false,
help = "Whether to reuse the DuckDB connection across iterations. Helpful when profiling \
to keep all work on the same threads"
)]
reuse: bool,
}

fn main() -> anyhow::Result<()> {
Expand Down Expand Up @@ -187,8 +195,11 @@ fn main() -> anyhow::Result<()> {
("benchmark_name", benchmark_name.clone()),
("query_idx", query_idx.to_string()),
]);

// Make sure to reopen the duckdb connection between iterations
ctx.reopen()?;
if !args.reuse {
ctx.reopen()?;
}
ctx.execute_query(query)
},
)?;
Expand Down
2 changes: 1 addition & 1 deletion vortex-datafusion/src/v2/source.rs
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ impl DataSource for VortexDataSource {
// Build the scan request with pushed-down projection, filter, and limit.
// The projection is included so the scan can prune columns at the I/O level.
let scan_request = ScanRequest {
projection: Some(self.projected_projection.clone()),
projection: self.projected_projection.clone(),
filter: self.filter.clone(),
limit: self.limit.map(|l| u64::try_from(l).unwrap_or(u64::MAX)),
ordered: self.ordered,
Expand Down
1 change: 1 addition & 0 deletions vortex-duckdb/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ custom-labels = { workspace = true }
futures = { workspace = true }
glob = { workspace = true }
itertools = { workspace = true }
kanal = { workspace = true }
num-traits = { workspace = true }
object_store = { workspace = true, features = ["aws"] }
parking_lot = { workspace = true }
Expand Down
Loading
Loading