Open
Conversation
…l functions Signed-off-by: Nicholas Gates <nick@nickgates.com>
…l functions Signed-off-by: Nicholas Gates <nick@nickgates.com>
Merging this PR will degrade performance by 27.45%
Performance Changes
Comparing 
Footnotes
|
github-actions
bot
removed
the
action/benchmark-sql
Contributor
|
@claude anything suspicious in this pr |
Contributor
|
Claude finished @0ax1's task in 3m 58s —— View job Review: Anything Suspicious in This PR
SummaryThe core intent of this PR is sound: the old code cast DuckDB's global data raw pointer to Here are the notable things worth looking at: 🔴 Minor Concern:
|
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
|
|
||
| fn copy_to_finalize( | ||
| bind_data: &Self::BindData, | ||
| init_global: &mut Self::GlobalState, |
Contributor
There was a problem hiding this comment.
This one should stay as mut and we would document they this and the above are different
| ) -> VortexResult<()> { | ||
| loop { | ||
| if local_state.exporter.is_none() { | ||
| let mut ctx = SESSION.create_execution_ctx(); |
| array_result | ||
| .execute::<Canonical>(&mut global_state.ctx)? | ||
| .into_struct() | ||
| array_result.execute::<Canonical>(&mut ctx)?.into_struct() |
| offset: usize, | ||
| len: usize, | ||
| vector: &mut VectorRef, | ||
| _ctx: &mut ExecutionCtx, |
myrrc
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6632
Previously we were casting the DuckDB global data pointer to a
&mut, which in Rust implies exclusive ownership. But this is not true since these callbacks were thread-local functions being given a pointer to the shared global data.This change meant fixing the scope of our use of ExecutionCtx to one per ArrayRef chunk (same scope as the ArrayExporter)