Merged
Conversation
1dc73bc to
989e43b
Compare
0ax1
reviewed
Feb 19, 2026
0ax1
reviewed
Feb 19, 2026
0ax1
reviewed
Feb 19, 2026
e9bc935 to
d7e5c3b
Compare
d7e5c3b to
575e591
Compare
575e591 to
1547002
Compare
joseph-isaacs
approved these changes
Feb 19, 2026
0ax1
reviewed
Feb 19, 2026
1547002 to
c69c86b
Compare
Contributor
Author
|
But yeah maybe it's best to keep the APIs aligned.
I believe if we can use one pointer we shouldn't pass three,
and as we reimplement table function's vtable anyway, we can cut
some corners, but this is minor, so I've reverted the code.
|
c69c86b to
2303af8
Compare
2303af8 to
5ae24d7
Compare
5ae24d7 to
4fd7dca
Compare
gatesn
reviewed
Feb 24, 2026
| let has_more_data = exporter.export(chunk)?; | ||
| global_state | ||
| .bytes_read | ||
| .fetch_add(chunk.len(), Ordering::Relaxed); |
Contributor
There was a problem hiding this comment.
This is wrong right? The variable is called bytes_read, but we're adding the row count of the chunk.
We're also adding this after pulling the chunk? So presumably the progress just hovers around or just below 100% the entire time?
I think we need to figure out a better measure of progress using the Scan API after #6652
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add table_scan_progress in duckdb's table function vtable. Return sum of read
(exported) chunks' length divided by sum of all chunks' length.
Unrelated changes:
Testing:
PRAGMA enable_progress_bar;
SET progress_bar_time = 10;
select * from read_vortex("/path/to/vortex/vortex-bench/data/tpch/10.0/vortex-file-compressed/l*.vortex");