Conversation
connortsui20
commented
Feb 17, 2026
| impl core::convert::From<vortex_mask::Mask> for core::option::Option<arrow_buffer::buffer::null::NullBuffer> | ||
|
|
||
| pub fn core::option::Option<arrow_buffer::buffer::null::NullBuffer>::from(value: vortex_mask::Mask) -> Self | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Don't really know why this was changed...
connortsui20
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
robert3005
reviewed
Feb 17, 2026
| // TODO(connor): Ideally we should filter directly on the `BufferHandle` once we implement | ||
| // `Filter` for that. | ||
| let filtered_buffer = array.to_buffer::<T>().filter(mask.as_ref()); | ||
| let filtered_buffer = super::buffer::filter_buffer(array.to_buffer::<T>(), mask.as_ref()); |
Contributor
There was a problem hiding this comment.
I think you still want to import this
Contributor
Author
There was a problem hiding this comment.
import as in move the path to the top of the file?
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/remove-vortex-compute
branch
from
9b8064e to
a51c461
Compare
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (1)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingSummary
Detailed Results Table
|
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
a10y
reviewed
Feb 17, 2026
Contributor
a10y
left a comment
a10y
left a comment
There was a problem hiding this comment.
seems good to me, i'll let someone else give final +1 but it's mainly moving stuff around, if it passes existing test suite i'm fine with it
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
connortsui20
added
the
action/benchmark
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
connortsui20
added
action/benchmark
robert3005
approved these changes
Feb 17, 2026
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
github-actions
bot
removed
the
action/benchmark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tracking Issue: #6547
Removes
vortex-computeand migrates some of the code that was used / should have been used fromvortex-computeinvortex-arrayinline.This is part of the effort to merge
vortex-dtypeintovortex-array.vortex-computewas just in the way because it depends on thevortex-dtypecrate butvortex-arraydepends onvortex-compute.API Changes
Removes all of
vortex-compute.Testing
N/A