fix is_sorted check failing for large multiplier values#6560
Merged
Conversation
a10y
force-pushed
the
aduffy/fix-sorted-seq
branch
from
2ccb6ce to
42dca6b
Compare
a10y
force-pushed
the
aduffy/fix-sorted-seq
branch
from
42dca6b to
1b3239f
Compare
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
a10y
force-pushed
the
aduffy/fix-sorted-seq
branch
from
1b3239f to
ebb60de
Compare
a10y
commented
Feb 17, 2026
a10y
commented
Feb 17, 2026
encodings/sequence/src/array.rs
Outdated
| multiplier, | ||
| uint: |v| { (true, v> 0) }, | ||
| int: |v| { (v >= 0, v > 0) }, | ||
| float: |v| { (!v.is_sign_negative(), v.is_sign_positive()) } |
Contributor
Author
There was a problem hiding this comment.
we probably shouldn't even allow SequenceArray of floats should we
Contributor
There was a problem hiding this comment.
I really thought it was banned in the ctor?
Contributor
Author
There was a problem hiding this comment.
i think it is. should i just put unreachable!() here then?
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
robert3005
reviewed
Feb 17, 2026
robert3005
approved these changes
Feb 17, 2026
dimitarvdimitrov
approved these changes
Feb 17, 2026
Contributor
dimitarvdimitrov
left a comment
dimitarvdimitrov
left a comment
There was a problem hiding this comment.
LGTM, IIRC @joseph-isaacs and I went with cast instead of the macro because a macro is more expensive (to compile?). But if that's causing correctness problems, then the macro it is
can't tell about the sequence array of floats
joseph-isaacs
approved these changes
Feb 17, 2026
Contributor
|
I would just use a i128 cast? |
Contributor
Author
|
i don't think the macro is more expensive, the |
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
a10y
force-pushed
the
aduffy/fix-sorted-seq
branch
from
99ba82a to
ac5d5d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the issue found by fuzzer in latest run
Seems like this snuck in on #6452