Skip to content

Remove vortex-vector#6529

Merged
connortsui20 merged 1 commit intodevelopfrom
ct/remove-vortex-vector
Feb 16, 2026
Merged

Remove vortex-vector#6529
connortsui20 merged 1 commit intodevelopfrom
ct/remove-vortex-vector

Conversation

@connortsui20
Copy link
Contributor

😢

We need to remove this now because we want to merge vortex-dtype into vortex-array, and if this still existed it would create a dependency cycle.

vortex-array --(depends on)--> vortex-vector --(depends on)--> vortex-dtype

vortex-array <--(depends on)--> vortex-dtype

😭

@connortsui20 connortsui20 added the changelog/break A breaking API change label Feb 16, 2026
@connortsui20 connortsui20 requested a review from 0ax1 February 16, 2026 14:31
@connortsui20 connortsui20 force-pushed the ct/remove-vortex-vector branch from 8e34113 to a76b012 Compare February 16, 2026 14:34
Copy link
Contributor

@a10y a10y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

destroy it

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 force-pushed the ct/remove-vortex-vector branch from a76b012 to 0b4477c Compare February 16, 2026 15:44
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 16, 2026

Merging this PR will improve performance by 11.52%

⚡ 8 improved benchmarks
✅ 1049 untouched benchmarks
⏩ 1346 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation encode_varbinview[(10000, 32)] 1.8 ms 1.7 ms +11.44%
Simulation encode_varbinview[(10000, 2)] 1.8 ms 1.6 ms +11.52%
Simulation encode_varbinview[(10000, 128)] 1.9 ms 1.7 ms +10.83%
Simulation encode_varbinview[(10000, 8)] 1.8 ms 1.7 ms +11.48%
Simulation encode_varbinview[(10000, 512)] 2 ms 1.8 ms +10.6%
Simulation encode_varbinview[(10000, 4)] 1.8 ms 1.6 ms +11.5%
Simulation compact_sliced[(16384, 90)] 1.9 ms 1.8 ms +10.25%
Simulation dict_compress_string 159.8 ms 145.2 ms +10.03%

Comparing ct/remove-vortex-vector (0b4477c) with develop (a3199a3)

Open in CodSpeed

Footnotes

  1. 1346 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@connortsui20
Copy link
Contributor Author

I should point out that I still think it is worth keeping this in our back pocket in case we want to replace our builders with these vectors.

With vortex-scalar being merged into vortex-array soon as well, we could actually have the completely type safe builders from vectors here!

@connortsui20 connortsui20 merged commit 33e85ff into develop Feb 16, 2026
48 checks passed
@connortsui20 connortsui20 deleted the ct/remove-vortex-vector branch February 16, 2026 16:01
@connortsui20
Copy link
Contributor Author

A moment of silence for vortex-vector (2025-2026)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants