Skip to content

dict of strings kernel to support outlined views#6401

Merged
onursatici merged 1 commit intodevelopfrom
os/dict-outlined-views
Feb 10, 2026
Merged

dict of strings kernel to support outlined views#6401
onursatici merged 1 commit intodevelopfrom
os/dict-outlined-views

Conversation

@onursatici
Copy link
Contributor

we don't move the buffer handles into the device, because we don't really care where they are. varbinview invariants should hold as long as the buffer index is correct on the outlined views

nullable test

Signed-off-by: Onur Satici <onur@spiraldb.com>
@onursatici onursatici added the changelog/feature A new feature label Feb 10, 2026
@onursatici onursatici enabled auto-merge (squash) February 10, 2026 16:11
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 10, 2026

Merging this PR will degrade performance by 26.11%

❌ 1 regressed benchmark
✅ 1137 untouched benchmarks
⏩ 1265 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_bool_into_canonical[(1000, 10)] 65.5 µs 88.6 µs -26.11%

Comparing os/dict-outlined-views (cbf4c1e) with develop (51c9571)2

Open in CodSpeed

Footnotes

  1. 1265 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (8f71558) during the generation of this report, so 51c9571 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@onursatici onursatici merged commit 6a4ca88 into develop Feb 10, 2026
85 of 151 checks passed
@onursatici onursatici deleted the os/dict-outlined-views branch February 10, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants