Merged
Conversation
github-actions
bot
removed
the
action/benchmark-sql
Contributor
Benchmarks: PolarSignals ProfilingSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
github-actions
bot
removed
the
action/benchmark-sql
github-actions
bot
removed
the
action/benchmark-sql
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (7)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: Random AccessSummary
Detailed Results Table
|
Contributor
|
I don't quite know how to review this. My preference is starting with something fast that then could have adjusted api instead of starting with a desired api that then cannot be made fast |
AdamGS
reviewed
Feb 19, 2026
AdamGS
reviewed
Feb 19, 2026
AdamGS
reviewed
Feb 19, 2026
AdamGS
reviewed
Feb 19, 2026
Contributor
|
Is there maybe a way to set these up as a additional benchmark variant for one of the benchmarks so we can see the constant comparison? |
robert3005
reviewed
Feb 19, 2026
Contributor
|
+1 for @robert3005 idea to benchmark both variants |
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
lwwmanning
reviewed
Feb 23, 2026
| /// Set the path glob for file discovery. | ||
| /// | ||
| /// This path should be relative to the filesystem's base URL. | ||
| pub fn with_glob(mut self, glob: impl Into<String>) -> Self { |
Contributor
There was a problem hiding this comment.
should figure out a way to pass a list of explicit files rather than a glob (listing files is slow on object storage)
Contributor
There was a problem hiding this comment.
Maybe we could lazily expand globs? Something along the lines of duckdb/duckdb#20619
Signed-off-by: Nicholas Gates <nick@nickgates.com>
lwwmanning
approved these changes
Feb 23, 2026
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experiment to use the Scan API from DuckDB and DataFusion integrations.
This PR introduces:
vortex::file::MultiFileDataSource- a data source builder that takes a listing of files, (in the future) unifies schemas, adds support for hive-style partitioning columns, etc, etc.vortex::scan::api- improvements to the Scan API as have become apparent while implementing support in two engines. I'd like to implement more engines before we decide on a path to stability.