Conversation
Signed-off-by: blaginin <github@blaginin.me>
Signed-off-by: blaginin <github@blaginin.me>
vortex-array/src/executor.rs
Outdated
| let trace = self.ops.join("\n"); | ||
| tracing::debug!("exec[{}] trace:\n{}", self.id, trace); |
There was a problem hiding this comment.
can we do this without a string alloc?
CodSpeed Performance ReportMerging this PR will degrade performance by 25.39%Comparing Summary
Performance Changes
Footnotes
|
Unable to generate the performance reportThere was an internal error while processing the run's data. We're working on fixing the issue. Feel free to contact us on Discord or at support@codspeed.io if the issue persists. |
| fn drop(&mut self) { | ||
| if !self.ops.is_empty() { | ||
| tracing::debug!("exec[{}] trace:\n{}", self.id, self.ops.iter().format("\n")); | ||
| if !self.ops.is_empty() && tracing::enabled!(tracing::Level::DEBUG) { |
There was a problem hiding this comment.
self.ops.iter().format("\n") with itertools?
There was a problem hiding this comment.
that's why this bug happened in the first place :D similar to prefix-dev/pixi#4938
There was a problem hiding this comment.
I thought this was fixed?
when there are several subscribers, i get: