Exporting struct array to arrow respects vortex nullabilty#6365
Merged
robert3005 merged 2 commits intodevelopfrom Feb 9, 2026
Merged
Exporting struct array to arrow respects vortex nullabilty#6365robert3005 merged 2 commits intodevelopfrom
robert3005 merged 2 commits intodevelopfrom
Conversation
Signed-off-by: Robert Kruszewski <github@robertk.io>
| // Update current_array to the result for chaining | ||
| current_array = expected_result.clone(); | ||
| ( | ||
| Action::Mask(Mask::from_iter(mask)), |
Contributor
There was a problem hiding this comment.
keep these as seperate they share cached state
Comment on lines
+118
to
+124
| let mask_true_count = mask.true_count(); | ||
| if mask_true_count == 0 { | ||
| // Fast-path for empty mask | ||
| return Ok(cast(array, &array.dtype().as_nullable())?.into()); | ||
| } | ||
|
|
||
| if matches!(mask, Mask::AllTrue(_)) { | ||
| if mask_true_count == mask.len() { |
Contributor
There was a problem hiding this comment.
this is a east and common mistake to make are you sure it exists?
Contributor
There was a problem hiding this comment.
the nice thing about the old version was that it avoided scanning the indices for the fast paths
Contributor
joseph-isaacs
left a comment
joseph-isaacs
left a comment
There was a problem hiding this comment.
which one is the actual fix? can we have a test?
a10y
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #6326
Signed-off-by: Robert Kruszewski github@robertk.io