-
Notifications
You must be signed in to change notification settings - Fork 127
feat[cuda]: export arrays to ArrowDeviceArray #6253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
a10y
wants to merge
14
commits into
develop
Choose a base branch
from
aduffy/c-device-iface
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+460
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9d62079 to
18f8a3d
Compare
a10y
commented
Feb 2, 2026
Merging this PR will not alter performance
Comparing Footnotes
|
3a8ddb6 to
a2d1c95
Compare
497d765 to
79b7afc
Compare
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
74549dc to
930f824
Compare
930f824 to
b489712
Compare
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds scaffolding for the first part of implementing export of Vortex Arrays directly to Arrow C Data Device Interface arrays, and implements the actual export for PrimitiveArray
Setup
Arrow defines a standard for exchanging data in-process to native code using the C Data Interface, which converts an Arrow array into a struct of pointers.
There is an (experimental, but mostly stable) extension called the C Data Device Interface which includes extra information such as the GPU device type and device ID.
cudf knows how to import data exported this way using the
from_arrow_device_columnmethod for column_views.We replicate the
ArrowArrayandArrowDeviceArraystructs from the spec.These are very similar to the existing FFI_ArrowArray and FFI_ArrowSchema structs from the
arrow-datacrate, except that those use arrow Bytes and real pointers and we need to use CUDA device pointers and BufferHandles.Testing
Rather than polluting the repo/CI with fetching and building cudf, I made a new repo https://github.com/vortex-data/cudf-test-harness/
This will load a cdylib, call its
export_array()function, imports it into cudf and calls some simple functions, then frees it by calling the embeddedreleasefunction pointer. This step is hooked up to CI now and only adds ~1m to the CUDA tests jobs.